hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3892) Few static methods of MiniDFSCluster class incorrectly assume that it is a singleton
Date Sat, 08 Sep 2012 06:16:08 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451261#comment-13451261
] 

Hadoop QA commented on HDFS-3892:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12544342/HDFS-3892.patch.1
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 16 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3161//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3161//console

This message is automatically generated.
                
> Few static methods of MiniDFSCluster class incorrectly assume that it is a singleton
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-3892
>                 URL: https://issues.apache.org/jira/browse/HDFS-3892
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Vlad Rozov
>            Assignee: Vlad Rozov
>            Priority: Minor
>             Fix For: 2.0.0-alpha
>
>         Attachments: HDFS-3892.patch, HDFS-3892.patch.1
>
>
> MiniDFSCluster class declares few methods including getBlockFile() and getStorageDirPath()
as static while MiniDFSCluster is not a singleton and allows multiple instances. There are
several unit tests that create and start more than one MiniDFSCluster at the same time.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message