Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7B553D98C for ; Wed, 15 Aug 2012 08:04:43 +0000 (UTC) Received: (qmail 71074 invoked by uid 500); 15 Aug 2012 08:04:42 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69275 invoked by uid 500); 15 Aug 2012 08:04:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 68394 invoked by uid 99); 15 Aug 2012 08:04:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2012 08:04:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 0B55A2C5BE2 for ; Wed, 15 Aug 2012 08:04:38 +0000 (UTC) Date: Wed, 15 Aug 2012 19:04:38 +1100 (NCT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <899371812.12177.1345017878047.JavaMail.jiratomcat@arcas> In-Reply-To: <1421448091.9654.1344977618091.JavaMail.jiratomcat@arcas> Subject: [jira] [Updated] (HDFS-3802) StartupOption.name in HdfsServerConstants should be final MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo (Nicholas), SZE updated HDFS-3802: ----------------------------------------- Affects Version/s: (was: 3.0.0) Fix Version/s: (was: 3.0.0) Hadoop Flags: Reviewed +1 patch looks good. > StartupOption.name in HdfsServerConstants should be final > --------------------------------------------------------- > > Key: HDFS-3802 > URL: https://issues.apache.org/jira/browse/HDFS-3802 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Trivial > Attachments: HDFS-3802.patch > > > In HdfsServerConstants, it may be better to define StartupOption.name as final since it will not and should not be modified after initialization. For example, in NameNode.java, the printUsage function prints out multiple startup options' names. The modification/change of the StartupOption.name may cause invalid usage message. Although right now there is no methods to change/set the value of StartupOption.name, it is better to add the final keyword to make sure. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira