Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 27 Aug 2012 18:53:07 +1100 (NCT)
From: "Vinay (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <893968951.834.1346053987905.JavaMail.jiratomcat@arcas>
In-Reply-To: <1609476602.19285.1345132298095.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3809) Make BKJM use protobufs for all
 serialization with ZK
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442325#comment-13442325 ] 

Vinay commented on HDFS-3809:
-----------------------------

Hi Ivan,
Patch looks nice. Following are the simple comments from my side.

{code}+      LOG.info("Reading " + path + " data: " + new String(data, UTF_8));{code}
Better to be in debug. Or logging only 'data' in debug also Ok.

Compilation Errors in TestBookKeeperJournalManager.java and TestBookKeeperConfiguration.java. Because of {{NamespaceInfo(int,String,String,int,int)}} contructor removal in HDFS-2686.

One doubt, Do we need to handle existing BKJM layout data compatibility, while reading the existing ledgers..?

CURRENT_INPROGRESS_LAYOUT_VERSION version check is removed from the CurrentInprogress.java, do you think this version check not required. In that case CURRENT_INPROGRESS_LAYOUT_VERSION 
and also CONTENT_DELIMITER can be removed from CurrentInprogress.java

In CurrentInprogressProto, why hostName is made optional.? is there any specific reason for it..? But i can see that previously always hostname was present in data.

TestCurrentInprogress.java has only one space change. I think, this can be removed from the patch.
                
> Make BKJM use protobufs for all serialization with ZK
> -----------------------------------------------------
>
>                 Key: HDFS-3809
>                 URL: https://issues.apache.org/jira/browse/HDFS-3809
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-3809.diff, HDFS-3809.diff
>
>
> HDFS uses protobufs for serialization in many places. Protobufs allow fields to be added without breaking bc or requiring new parsing code to be written. For this reason, we should use them in BKJM also.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira