Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 25B1C9FAB for ; Fri, 31 Aug 2012 04:03:14 +0000 (UTC) Received: (qmail 39526 invoked by uid 500); 31 Aug 2012 04:03:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 38675 invoked by uid 500); 31 Aug 2012 04:03:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 37764 invoked by uid 99); 31 Aug 2012 04:03:09 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Aug 2012 04:03:09 +0000 Date: Fri, 31 Aug 2012 15:03:09 +1100 (NCT) From: "Eli Collins (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <88998058.20380.1346385789393.JavaMail.jiratomcat@arcas> In-Reply-To: <1185097729.393.1328484122045.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Assigned] (HDFS-2896) The 2NN incorrectly daemonizes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eli Collins reassigned HDFS-2896: --------------------------------- Assignee: (was: Eli Collins) > The 2NN incorrectly daemonizes > ------------------------------ > > Key: HDFS-2896 > URL: https://issues.apache.org/jira/browse/HDFS-2896 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 0.23.0, 0.24.0 > Reporter: Eli Collins > Labels: newbie > > The SecondaryNameNode (and Checkpointer) confuse o.a.h.u.Daemon with a Unix daemon. Per below it intends to create a thread that never ends, but o.a.h.u.Daemon just marks a thread with Java's Thread#setDaemon which means Java will terminate the thread when there are no more non-daemon user threads running > {code} > // Create a never ending deamon > Daemon checkpointThread = new Daemon(secondary); > {code} > Perhaps they thought they were using commons Daemon. We of course don't want the 2NN to exit unless it exits itself or is stopped explicitly. Currently it won't do this because the main thread is not marked as a daemon thread. In any case, let's make the 2NN consistent with the NN in this regard (exit when the RPC thread exits). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira