Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 29 Aug 2012 04:16:09 +1100 (NCT)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <850376270.7183.1346174169071.JavaMail.jiratomcat@arcas>
In-Reply-To: <887759690.848.1345651903274.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3837) Fix DataNode.recoverBlock findbugs
 warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443286#comment-13443286 ] 

Suresh Srinivas commented on HDFS-3837:
---------------------------------------

If this is a findbugs issue, why not just add this to findbugs exclude?
                
> Fix DataNode.recoverBlock findbugs warning
> ------------------------------------------
>
>                 Key: HDFS-3837
>                 URL: https://issues.apache.org/jira/browse/HDFS-3837
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3837.txt, hdfs-3837.txt, hdfs-3837.txt
>
>
> HDFS-2686 introduced the following findbugs warning:
> {noformat}
> Call to equals() comparing different types in org.apache.hadoop.hdfs.server.datanode.DataNode.recoverBlock(BlockRecoveryCommand$RecoveringBlock)
> {noformat}
> Both are using DatanodeID#equals but it's a different method because DNR#equals overrides equals for some reason (doesn't change behavior).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira