Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 24 Aug 2012 04:43:42 +1100 (NCT)
From: "Kihwal Lee (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <2074305864.6463.1345743822515.JavaMail.jiratomcat@arcas>
In-Reply-To: <399691691.6196.1345740282635.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3848) A Bug in recoverLeaseInternal method
 of FSNameSystem class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440481#comment-13440481 ] 

Kihwal Lee commented on HDFS-3848:
----------------------------------

Good find! 

I think we can just get rid of {{lease.getHolder().equals(holder)}}. The first condition, {{(leaseFile != null && leaseFile.equals(lease))}}, is sufficient, because {{Lease#equals()}} checks whether the holders are equal.


> A Bug in recoverLeaseInternal method of FSNameSystem class
> ----------------------------------------------------------
>
>                 Key: HDFS-3848
>                 URL: https://issues.apache.org/jira/browse/HDFS-3848
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.1
>            Reporter: Hooman Peiro Sajjad
>              Labels: patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This is a bug in logic of the method recoverLeaseInternal. In line 1322 it checks if the owner of the file is trying to recreate the file. The condition of the if statement is 
> (leaseFile != null && leaseFile.equals(lease)) || lease.getHolder().equals(holder)
> As it can be seen, there are two operands (conditions) connected with an "or" operator. The first operand is straight and will be true only if the holder of the file is the new holder. But the problem is the second operand which will be always true since the "lease" object is the one found by the "holder" by calling "Lease lease = leaseManager.getLease(holder);" in line 1315.
> To fix this I think the if statement only should contain the following the condition:
> (leaseFile != null && leaseFile.getHolder().equals(holder))

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira