Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 42465DD2D for ; Thu, 16 Aug 2012 14:33:39 +0000 (UTC) Received: (qmail 26525 invoked by uid 500); 16 Aug 2012 14:33:39 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 26480 invoked by uid 500); 16 Aug 2012 14:33:39 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 26364 invoked by uid 99); 16 Aug 2012 14:33:38 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Aug 2012 14:33:38 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 236942C5BEE for ; Thu, 16 Aug 2012 14:33:38 +0000 (UTC) Date: Fri, 17 Aug 2012 01:33:38 +1100 (NCT) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <2059713777.18979.1345127618145.JavaMail.jiratomcat@arcas> In-Reply-To: <1478976591.1207.1333385124633.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-3177) Allow DFSClient to find out and use the CRC type being used for a file. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435995#comment-13435995 ] Hadoop QA commented on HDFS-3177: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12541213/hdfs-3177-with-hadoop-8239-8240.patch.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.hdfs.TestReplication org.apache.hadoop.hdfs.TestFileAppend2 org.apache.hadoop.hdfs.TestReplaceDatanodeOnFailure +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3023//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3023//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3023//console This message is automatically generated. > Allow DFSClient to find out and use the CRC type being used for a file. > ----------------------------------------------------------------------- > > Key: HDFS-3177 > URL: https://issues.apache.org/jira/browse/HDFS-3177 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, hdfs client > Affects Versions: 0.23.0 > Reporter: Kihwal Lee > Assignee: Kihwal Lee > Fix For: 2.1.0-alpha, 3.0.0 > > Attachments: hdfs-3177-after-hadoop-8239-8240.patch.txt, hdfs-3177.patch, hdfs-3177-with-hadoop-8239-8240.patch.txt > > > To support HADOOP-8060, DFSClient should be able to find out the checksum type being used for files in hdfs. > In my prototype, DataTransferProtocol was extended to include the checksum type in the blockChecksum() response. DFSClient uses it in getFileChecksum() to determin the checksum type. Also append() can be configured to use the existing checksum type instead of the configured one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira