Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F1BBDB2A for ; Fri, 24 Aug 2012 00:02:43 +0000 (UTC) Received: (qmail 73515 invoked by uid 500); 24 Aug 2012 00:02:42 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 73448 invoked by uid 500); 24 Aug 2012 00:02:42 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 73344 invoked by uid 99); 24 Aug 2012 00:02:42 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Aug 2012 00:02:42 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 84DDD2C0A62 for ; Fri, 24 Aug 2012 00:02:42 +0000 (UTC) Date: Fri, 24 Aug 2012 11:02:42 +1100 (NCT) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1855863167.8399.1345766562545.JavaMail.jiratomcat@arcas> In-Reply-To: <338154797.76836.1342719754991.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3683) Edit log replay progress indicator shows >100% complete MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440806#comment-13440806 ] Hadoop QA commented on HDFS-3683: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12542195/HDFS_3683.patch against trunk revision . -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3082//console This message is automatically generated. > Edit log replay progress indicator shows >100% complete > ------------------------------------------------------- > > Key: HDFS-3683 > URL: https://issues.apache.org/jira/browse/HDFS-3683 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Affects Versions: 2.0.0-alpha > Reporter: Todd Lipcon > Assignee: Plamen Jeliazkov > Priority: Minor > Attachments: HDFS_3683.patch > > > When loading a large edit log, the NameNode prints a percentage-complete progress indicator: > {code} > int percent = Math.round((float)lastAppliedTxId / numTxns * 100); > LOG.info("replaying edit log: " + lastAppliedTxId + "/" + numTxns > + " transactions completed. (" + percent + "%)"); > {code} > But the percentage is calculated incorrectly, since it divides the transaction ID by the number of expected transactions. This only works when starting at txid 1. (eg if we are loading 1000 transaction starting at txid 1000, the indicator will start at 100% and go to 200%) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira