Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 21 Aug 2012 14:26:38 +1100 (NCT)
From: "Eli Collins (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1500333806.33427.1345519598141.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1999374075.51022.1325150490833.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2727) hdfs.c uses deprecated property
 dfs.block.size
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438426#comment-13438426 ] 

Eli Collins commented on HDFS-2727:
-----------------------------------

+1

Nit: the diff to jni_helper.c is a nop (removes the EOL), I'll revert it
                
> hdfs.c uses deprecated property dfs.block.size
> ----------------------------------------------
>
>                 Key: HDFS-2727
>                 URL: https://issues.apache.org/jira/browse/HDFS-2727
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 0.23.0, 2.2.0-alpha
>            Reporter: Sho Shimauchi
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-2727.001.patch, HDFS-2727.002.patch
>
>
> libhdfs uses the deprecated property {{dfs.block.size}}.  It would be better for libhdfs to use the FileSystem#getDefaultBlockSize API instead.
> This API has two advantages:
> 1. It uses the new, non-deprecated {{dfs.blocksize}} property
> 2. It handles string escapes like 'M' for 'megabytes' etc. which can appear in {{dfs.blocksize}} and {{dfs.block.size}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira