Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 18 Aug 2012 13:29:38 +1100 (NCT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1394476094.26083.1345256978016.JavaMail.jiratomcat@arcas>
In-Reply-To: <1042178658.25958.1345251097938.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3816)
 DFSConfigKeys.DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT should
 be 0.32f, instead of 32
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437215#comment-13437215 ] 

Hadoop QA commented on HDFS-3816:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12541451/HDFS-3816.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3039//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3039//console

This message is automatically generated.
                
> DFSConfigKeys.DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT should be 0.32f, instead of 32
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3816
>                 URL: https://issues.apache.org/jira/browse/HDFS-3816
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>             Fix For: 3.0.0
>
>         Attachments: HDFS-3816.patch
>
>
> HDFS-3475 used blocksInvalidateWorkPct/DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT as a percentage float number. Thus DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT should be defined as a float number with value 0.32f.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira