Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 24 Aug 2012 08:16:43 +1100 (NCT)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1229348124.7568.1345756603179.JavaMail.jiratomcat@arcas>
In-Reply-To: <887759690.848.1345651903274.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3837) Fix DataNode.recoverBlock findbugs
 warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440671#comment-13440671 ] 

Hudson commented on HDFS-3837:
------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #2695 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2695/])
    Revert HDFS-3837. Fix DataNode.recoverBlock findbugs warning. (Revision 1376701)

     Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1376701
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/protocol/DatanodeRegistration.java

                
> Fix DataNode.recoverBlock findbugs warning
> ------------------------------------------
>
>                 Key: HDFS-3837
>                 URL: https://issues.apache.org/jira/browse/HDFS-3837
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 2.2.0-alpha
>
>         Attachments: hdfs-3837.txt
>
>
> HDFS-2686 introduced the following findbugs warning:
> {noformat}
> Call to equals() comparing different types in org.apache.hadoop.hdfs.server.datanode.DataNode.recoverBlock(BlockRecoveryCommand$RecoveringBlock)
> {noformat}
> Both are using DatanodeID#equals but it's a different method because DNR#equals overrides equals for some reason (doesn't change behavior).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira