Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 22 Aug 2012 14:46:38 +1100 (NCT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1228366844.38356.1345607198602.JavaMail.jiratomcat@arcas>
In-Reply-To: <1908948305.31676.1345495178018.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HDFS-3819) Should check whether invalidate work
 percentage default value is not greater than 1.0f
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439255#comment-13439255 ] 

Hadoop QA commented on HDFS-3819:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12541650/HDFS-3819.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3063//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3063//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3063//console

This message is automatically generated.
                
> Should check whether invalidate work percentage default value is not greater than 1.0f
> --------------------------------------------------------------------------------------
>
>                 Key: HDFS-3819
>                 URL: https://issues.apache.org/jira/browse/HDFS-3819
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.2.0-alpha
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-3819_branch1.1.patch, HDFS-3819.patch, HDFS-3819.patch
>
>
> In DFSUtil#getInvalidateWorkPctPerIteration we should also check that the configured value is not greater than 1.0f.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira