Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 69CA1DCDC for ; Wed, 1 Aug 2012 21:42:03 +0000 (UTC) Received: (qmail 19780 invoked by uid 500); 1 Aug 2012 21:42:03 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 19735 invoked by uid 500); 1 Aug 2012 21:42:03 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 19718 invoked by uid 99); 1 Aug 2012 21:42:03 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2012 21:42:03 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id E2B58142851 for ; Wed, 1 Aug 2012 21:42:02 +0000 (UTC) Date: Wed, 1 Aug 2012 21:42:02 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1183185633.2374.1343857322930.JavaMail.jiratomcat@issues-vm> In-Reply-To: <690610644.72037.1342648416949.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3680) Allows customized audit logging in HDFS FSNamesystem MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3680?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D13426= 929#comment-13426929 ]=20 Suresh Srinivas commented on HDFS-3680: --------------------------------------- I have not looked at the patch. I will review it later.=20 Thinking more about the approach, just removing audit logger on the first e= xception has many issue we need to consider. # With this approach, should namenode run if for some reason we have remove= d all the audit loggers from the list? My answer would be no, given the imp= ortance of audit log. # Does the system need a mechanism to add/remove audit loggers? When a fail= ed logger is fixed, do we need a way to refresh the audit logger so it is p= icked up by the Namenode again? # When you have multiple audit loggers, is there a need to keep them in syn= c or out of sync audit loggers okay? # Alternatively, should we consider a separate daemon that runs off of the = audit log written to disk and updates other syncs instead of doing it inlin= e in the namenode code? =20 > Allows customized audit logging in HDFS FSNamesystem > ---------------------------------------------------- > > Key: HDFS-3680 > URL: https://issues.apache.org/jira/browse/HDFS-3680 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Affects Versions: 2.0.0-alpha > Reporter: Marcelo Vanzin > Assignee: Marcelo Vanzin > Priority: Minor > Attachments: accesslogger-v1.patch, accesslogger-v2.patch, hdfs-3= 680-v3.patch, hdfs-3680-v4.patch, hdfs-3680-v5.patch > > > Currently, FSNamesystem writes audit logs to a logger; that makes it easy= to get audit logs in some log file. But it makes it kinda tricky to store = audit logs in any other way (let's say a database), because it would requir= e the code to implement a log appender (and thus know what logging system i= s actually being used underneath the fa=C3=A7ade), and parse the textual lo= g message generated by FSNamesystem. > I'm attaching a patch that introduces a cleaner interface for this use ca= se. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira