hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3837) Fix DataNode.recoverBlock findbugs warning
Date Thu, 30 Aug 2012 18:21:10 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Eli Collins updated HDFS-3837:

    Attachment: hdfs-3837.txt

No problem, can always do cleanup in another change. Updated patch just does adds an exclude.

Thanks for the reviews Suresh.
> Fix DataNode.recoverBlock findbugs warning
> ------------------------------------------
>                 Key: HDFS-3837
>                 URL: https://issues.apache.org/jira/browse/HDFS-3837
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>         Attachments: hdfs-3837.txt, hdfs-3837.txt, hdfs-3837.txt, hdfs-3837.txt, hdfs-3837.txt
> HDFS-2686 introduced the following findbugs warning:
> {noformat}
> Call to equals() comparing different types in org.apache.hadoop.hdfs.server.datanode.DataNode.recoverBlock(BlockRecoveryCommand$RecoveringBlock)
> {noformat}
> Both are using DatanodeID#equals but it's a different method because DNR#equals overrides
equals for some reason (doesn't change behavior).

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message