hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3798) Avoid throwing NPE when finalizeSegment() is called on invalid segment
Date Tue, 14 Aug 2012 17:57:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434329#comment-13434329
] 

Aaron T. Myers commented on HDFS-3798:
--------------------------------------

The tests which catch expected exceptions should call fail() if the exception isn't thrown.

Otherwise the patch looks good. +1 once this is addressed.
                
> Avoid throwing NPE when finalizeSegment() is called on invalid segment
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3798
>                 URL: https://issues.apache.org/jira/browse/HDFS-3798
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: QuorumJournalManager (HDFS-3077)
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Trivial
>         Attachments: hdfs-3798.txt
>
>
> Currently, if the client calls finalizeLogSegment() on a segment which doesn't exist
on the JournalNode side, it throws an NPE. Instead it should throw a more intelligible exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message