hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3796) Speed up edit log tests by avoiding fsync()
Date Tue, 14 Aug 2012 02:44:37 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433841#comment-13433841
] 

Hadoop QA commented on HDFS-3796:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12540787/hdfs-3796.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2998//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2998//console

This message is automatically generated.
                
> Speed up edit log tests by avoiding fsync()
> -------------------------------------------
>
>                 Key: HDFS-3796
>                 URL: https://issues.apache.org/jira/browse/HDFS-3796
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 3.0.0, 2.2.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3796.txt
>
>
> Our edit log tests are very slow because they incur a lot of fsyncs as they write out
transactions. Since fsync() has no effect except in the case of power outages or system crashes,
and we don't care about power outages in the context of tests, we can safely skip the fsync
without any loss in coverage.
> In my tests, this sped up TestEditLog by about 5x. The testFuzzSequences test case improved
from ~83 seconds with fsync to about 5 seconds without. These results are from my SSD laptop
- they are probably even more drastic on spinning media.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message