hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3723) All commands should support meaningful --help
Date Mon, 13 Aug 2012 21:44:38 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jing Zhao updated HDFS-3723:
----------------------------

    Attachment: HDFS-3723.001.patch

Suresh, thanks for the comments. I have addressed the comments and added a help function in
DFSUtil. I used the function to parse and check the help argument for commands DataNode, NameNode,
ZKFC, FSCK, Balancer, GetConf, and GetGroups. Other commands such as JmxGet have their own
mechanisms to handle help argument, so I did not change them.
                
> All commands should support meaningful --help
> ---------------------------------------------
>
>                 Key: HDFS-3723
>                 URL: https://issues.apache.org/jira/browse/HDFS-3723
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: scripts, tools
>    Affects Versions: 2.0.0-alpha
>            Reporter: E. Sammer
>            Assignee: Jing Zhao
>         Attachments: HDFS-3723.001.patch, HDFS-3723.patch, HDFS-3723.patch
>
>
> Some (sub)commands support -help or -h options for detailed help while others do not.
Ideally, all commands should support meaningful help that works regardless of current state
or configuration.
> For example, hdfs zkfc --help (or -h or -help) is not very useful. Option checking should
occur before state / configuration checking.
> {code}
> [esammer@hadoop-fed01 ~]# hdfs zkfc --help
> Exception in thread "main" org.apache.hadoop.HadoopIllegalArgumentException: HA is not
enabled for this namenode.
>         at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.setConf(DFSZKFailoverController.java:122)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:66)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>         at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.main(DFSZKFailoverController.java:168)
> {code}
> This would go a long way toward better usability for ops staff.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message