hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3683) Edit log replay progress indicator shows >100% complete
Date Fri, 24 Aug 2012 03:25:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440906#comment-13440906
] 

Hadoop QA commented on HDFS-3683:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542225/HDFS_3683.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner
                  org.apache.hadoop.hdfs.TestHftpDelegationToken
                  org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3085//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3085//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3085//console

This message is automatically generated.
                
> Edit log replay progress indicator shows >100% complete
> -------------------------------------------------------
>
>                 Key: HDFS-3683
>                 URL: https://issues.apache.org/jira/browse/HDFS-3683
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Plamen Jeliazkov
>            Priority: Minor
>         Attachments: HDFS_3683.patch, HDFS_3683.patch
>
>
> When loading a large edit log, the NameNode prints a percentage-complete progress indicator:
> {code}
>               int percent = Math.round((float)lastAppliedTxId / numTxns * 100);
>               LOG.info("replaying edit log: " + lastAppliedTxId + "/" + numTxns
>                   + " transactions completed. (" + percent + "%)");
> {code}
> But the percentage is calculated incorrectly, since it divides the transaction ID by
the number of expected transactions. This only works when starting at txid 1. (eg if we are
loading 1000 transaction starting at txid 1000, the indicator will start at 100% and go to
200%)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message