hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Isaacson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3634) Add self-contained, mavenized fuse_dfs test
Date Tue, 07 Aug 2012 02:03:02 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429662#comment-13429662
] 

Andy Isaacson commented on HDFS-3634:
-------------------------------------

{code}
+    req.tv_sec = rem.tv_sec;
+    req.tv_nsec = rem.tv_nsec;
{code}
This can simply be written {{req = rem;}}.
{code}
+  } while (rem.tv_sec || rem.tv_nsec);
{code}
I don't see anywhere in the docs that say {{rem}} is zeroed on successful sleep, nor that
it isn't modified on successful sleep.  The docs say the return value will be 0 on successful
sleep.  So we should do something like
{code}
   do {
      req = rem;
      ret = nanosleep(&req, &rem);
   } while (ret == -1 && errno == EINTR);
   if (ret == -1) {
       fprintf(stderr, "sleepNoSig: nanosleep: %s\n", strerror(errno));
   }
{code}

                
> Add self-contained, mavenized fuse_dfs test
> -------------------------------------------
>
>                 Key: HDFS-3634
>                 URL: https://issues.apache.org/jira/browse/HDFS-3634
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: fuse-dfs
>    Affects Versions: 2.1.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3634.002.patch, HDFS-3634.003.patch, HDFS-3634.004.patch
>
>
> We should have a self-contained, mavenized FUSE unit test which runs as part of the normal
build and can detect problems.  Of course, because FUSE is an optional build component, the
unit test won't run unless the user has FUSE installed.  However, it would be very useful
in improving the quality of fuse_dfs and detecting regressions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message