hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3846) Namenode deadlock in branch-1
Date Thu, 23 Aug 2012 20:32:42 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440630#comment-13440630
] 

Brandon Li commented on HDFS-3846:
----------------------------------

test-patch result:
{noformat}
-1 overall.  
    +1 @author.  The patch does not contain any @author tags.
    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.
    +1 javadoc.  The javadoc tool did not generate any warning messages.
    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
    -1 findbugs.  The patch appears to introduce 195 new Findbugs (version 2.0.0) warnings.
{noformat}

The patch doesn't introduce new findbugs warning.
It's hard to write a unit test for it. The problem is not very reproducible neither.
 
                
> Namenode deadlock in branch-1
> -----------------------------
>
>                 Key: HDFS-3846
>                 URL: https://issues.apache.org/jira/browse/HDFS-3846
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Brandon Li
>         Attachments: HDFS-3846.branch-1.patch
>
>
> Jitendra found out the following problem:
> 1. Handler : Acquires namesystem lock waits on SafemodeInfo lock at SafeModeInfo.isOn()
> 2. SafemodeMonitor : Calls SafeModeInfo.canLeave() which is synchronized so SafemodeInfo
lock is acquired, but this method also causes following call sequence needEnter() -> getNumLiveDataNodes()
-> getNumberOfDatanodes() -> getDatanodeListForReport() -> getDatanodeListForReport()
. The getDatanodeListForReport is synchronized with FSNamesystem lock.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message