hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3834) Unused Command.java fields NAME, DESCRIPTION and USAGE
Date Wed, 22 Aug 2012 18:34:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439741#comment-13439741
] 

Hadoop QA commented on HDFS-3834:
---------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12541841/HDFS-3834.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-common-project/hadoop-common.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3068//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3068//console

This message is automatically generated.
                
> Unused Command.java fields NAME, DESCRIPTION and USAGE
> ------------------------------------------------------
>
>                 Key: HDFS-3834
>                 URL: https://issues.apache.org/jira/browse/HDFS-3834
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-3834.patch
>
>
> The static fields NAME, USAGE AND DESCRIPTION in Command.java are not used and cannot
be overridden by subclasses since Java does not support static variable overriding. We can
get rid of these three fields in the Command.java and only keep them as static fields in subclasses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message