hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2695) ReadLock should be enough for FsNameSystem#renewLease.
Date Thu, 30 Aug 2012 16:30:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445070#comment-13445070

Hadoop QA commented on HDFS-2695:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3123//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/3123//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3123//console

This message is automatically generated.
> ReadLock should be enough for FsNameSystem#renewLease.
> ------------------------------------------------------
>                 Key: HDFS-2695
>                 URL: https://issues.apache.org/jira/browse/HDFS-2695
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-2695.patch
> When checking the issue HDFS-1241, found this point.
> Since renewLease is not updating any nameSystem related data, can we make this lock to
read lock?
> am i missing some thing here? 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message