hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3723) All commands should support meaningful --help
Date Wed, 01 Aug 2012 01:14:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426263#comment-13426263
] 

Hadoop QA commented on HDFS-3723:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12538630/HDFS-3723.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.ha.TestHAAdmin
                  org.apache.hadoop.hdfs.tools.TestDFSHAAdmin

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2933//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2933//console

This message is automatically generated.
                
> All commands should support meaningful --help
> ---------------------------------------------
>
>                 Key: HDFS-3723
>                 URL: https://issues.apache.org/jira/browse/HDFS-3723
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: scripts, tools
>    Affects Versions: 2.0.0-alpha
>            Reporter: E. Sammer
>            Assignee: Jing Zhao
>         Attachments: HDFS-3723.patch
>
>
> Some (sub)commands support -help or -h options for detailed help while others do not.
Ideally, all commands should support meaningful help that works regardless of current state
or configuration.
> For example, hdfs zkfc --help (or -h or -help) is not very useful. Option checking should
occur before state / configuration checking.
> {code}
> [esammer@hadoop-fed01 ~]# hdfs zkfc --help
> Exception in thread "main" org.apache.hadoop.HadoopIllegalArgumentException: HA is not
enabled for this namenode.
>         at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.setConf(DFSZKFailoverController.java:122)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:66)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>         at org.apache.hadoop.hdfs.tools.DFSZKFailoverController.main(DFSZKFailoverController.java:168)
> {code}
> This would go a long way toward better usability for ops staff.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message