hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3707) TestFSInputChecker: improper use of skip
Date Mon, 20 Aug 2012 23:32:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438306#comment-13438306

Hadoop QA commented on HDFS-3707:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3047//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3047//console

This message is automatically generated.
> TestFSInputChecker: improper use of skip
> ----------------------------------------
>                 Key: HDFS-3707
>                 URL: https://issues.apache.org/jira/browse/HDFS-3707
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.0-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-3707.001.patch, hdfs-3707.txt
> TestFSInputChecker assumes that FSDataInputStream#skip always skips the full amount of
bytes.  However, FSDataInputStream inherits this method from InputStream.  InputStream#skip
skips "up to" the requested number of bytes.  It is not an error if it skips fewer.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message