hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3816) Invalidate work percentage default value should be 0.32f instead of 32
Date Mon, 20 Aug 2012 18:29:38 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438061#comment-13438061
] 

Aaron T. Myers commented on HDFS-3816:
--------------------------------------

Good find, Jing.

One suggestion: perhaps in DFSUtil#getInvalidateWorkPctPerIteration we should also check that
the configured value of this config is not greater than 1.0f? If I'm reading the code correctly,
it doesn't make any sense to set this value to anything outside of the range 0.0f-1.0f. Jing,
if you agree with this, mind filing another JIRA? I'd be happy to review it if you post a
patch. If not, I'll take care of it.

Also, Suresh, did you commit this to branch-2.1.0-alpha as well as branch-2? If not, I believe
the fix version should be set to 2.2.0-alpha. Do you agree?
                
> Invalidate work percentage default value should be 0.32f instead of 32
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3816
>                 URL: https://issues.apache.org/jira/browse/HDFS-3816
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 2.1.0-alpha, 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>             Fix For: 2.1.0-alpha, 3.0.0
>
>         Attachments: HDFS-3816.patch, HDFS-3816.patch
>
>
> HDFS-3475 used blocksInvalidateWorkPct/DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT
as a percentage float number. Thus DFS_NAMENODE_INVALIDATE_WORK_PCT_PER_ITERATION_DEFAULT
should be defined as a float number with value 0.32f.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message