hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3860) HeartbeatManager#Monitor may wrongly hold the writelock of namesystem
Date Tue, 28 Aug 2012 18:34:07 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443353#comment-13443353
] 

Hudson commented on HDFS-3860:
------------------------------

Integrated in Hadoop-Common-trunk-Commit #2651 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2651/])
    HDFS-3860. HeartbeatManager#Monitor may wrongly hold the writelock of namesystem. Contributed
by Jing Zhao. (Revision 1378228)

     Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378228
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/HeartbeatManager.java

                
> HeartbeatManager#Monitor may wrongly hold the writelock of namesystem
> ---------------------------------------------------------------------
>
>                 Key: HDFS-3860
>                 URL: https://issues.apache.org/jira/browse/HDFS-3860
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>             Fix For: 2.2.0-alpha
>
>         Attachments: HDFS-3860.patch, HDFS-heartbeat-testcase.patch
>
>
> In HeartbeatManager#heartbeatCheck, if some dead datanode is found, the monitor thread
will acquire the write lock of namesystem, and recheck the safemode. If it is in safemode,
the monitor thread will return from the heartbeatCheck function without release the write
lock. This may cause the monitor thread wrongly holding the write lock forever.
> The attached test case tries to simulate this bad scenario.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message