hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daryn Sharp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3834) Unused Command.java fields NAME, DESCRIPTION and USAGE
Date Wed, 22 Aug 2012 13:57:43 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439530#comment-13439530
] 

Daryn Sharp commented on HDFS-3834:
-----------------------------------

I'd not thrilled with the static fields, but I left it that way when overhauling {{FsShell}}
to maintain compatibility while incrementally converting commands.  {{DFSAdmin}} is also using
the class, so you may want to double check that it has no problem with the change.  I don't
think it should, so +1 if {{DFSAdmin}} has no problems.
                
> Unused Command.java fields NAME, DESCRIPTION and USAGE
> ------------------------------------------------------
>
>                 Key: HDFS-3834
>                 URL: https://issues.apache.org/jira/browse/HDFS-3834
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-3834.patch
>
>
> The static fields NAME, USAGE AND DESCRIPTION in Command.java are not used and cannot
be overridden by subclasses since Java does not support static variable overriding. We can
get rid of these three fields in the Command.java and only keep them as static fields in subclasses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message