Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 11 Jul 2012 21:45:34 +0000 (UTC)
From: "Daryn Sharp (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <692273498.38244.1342043134715.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <246559683.37213.1342032694691.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3639) JspHelper#getUGI should always
 verify the token if security is enabled
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412034#comment-13412034 ] 

Daryn Sharp commented on HDFS-3639:
-----------------------------------

+1 (Assuming tests pass) I saw that while fixing proxy tokens and it make me uneasy so I'm glad you're fixing it!
                
> JspHelper#getUGI should always verify the token if security is enabled
> ----------------------------------------------------------------------
>
>                 Key: HDFS-3639
>                 URL: https://issues.apache.org/jira/browse/HDFS-3639
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3639.txt
>
>
> JspHelper#getUGI on verifies the given token if the context and nn are set (added in HDFS-2416). We should unconditionally verifyToken the token, ie a bug where "name.node" is not set in the context object should not result in not verifying the token. In practice this shouldn't be an issue as per HDFS-3434 the context and NN should never be null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira