Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 27 Jul 2012 22:55:35 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <45481543.112153.1343429735018.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <40138863.70514.1342636655028.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3679) fuse_dfs notrash option sets
 usetrash
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424204#comment-13424204 ] 

Hudson commented on HDFS-3679:
------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #2550 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2550/])
    HDFS-3679. fuse_dfs notrash option sets usetrash. Contributed by Conrad Meyer. (Revision 1366545)

     Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1366545
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c

                
> fuse_dfs notrash option sets usetrash
> -------------------------------------
>
>                 Key: HDFS-3679
>                 URL: https://issues.apache.org/jira/browse/HDFS-3679
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: fuse-dfs
>    Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0-alpha
>            Reporter: Conrad Meyer
>            Assignee: Conrad Meyer
>            Priority: Minor
>             Fix For: 1.2.0, 2.1.0-alpha
>
>         Attachments: hdfs-3679.diff
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> fuse_dfs sets usetrash option when the "notrash" flag is given. This is the exact opposite of the desired behavior. The "usetrash" flag sets usetrash as well, but this is correct. Here are the relevant lines from fuse_options.c, in latest HDFS HEAD[0]:
> 123	  case KEY_USETRASH:
> 124	    options.usetrash = 1;
> 125	    break;
> 126	  case KEY_NOTRASH:
> 127	    options.usetrash = 1;
> 128	    break;
> This is a pretty trivial bug to fix. I'm not familiar with the process here, but I can attach a patch if needed.
> [0]: https://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c?view=markup

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira