Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 10 Jul 2012 12:54:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <302052456.28033.1341924874847.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <237749180.26543.1341896914898.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3623) BKJM: zkLatchWaitTimeout hard coded
 to 6000. Make use of ZKSessionTimeout instead.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410313#comment-13410313 ] 

Hadoop QA commented on HDFS-3623:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12535814/HDFS-3628.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2771//console

This message is automatically generated.
                
> BKJM: zkLatchWaitTimeout hard coded to 6000. Make use of ZKSessionTimeout instead.
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-3623
>                 URL: https://issues.apache.org/jira/browse/HDFS-3623
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-3628.patch
>
>
> {code}
> if (!zkConnectLatch.await(6000, TimeUnit.MILLISECONDS)) {
> {code}
> we can make use of session timeout instead of hardcoding this value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira