Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3BA7A9C0F for ; Wed, 18 Jul 2012 19:56:05 +0000 (UTC) Received: (qmail 41548 invoked by uid 500); 18 Jul 2012 19:56:05 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 41506 invoked by uid 500); 18 Jul 2012 19:56:05 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 41465 invoked by uid 99); 18 Jul 2012 19:56:04 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jul 2012 19:56:04 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id DDE421427F2 for ; Wed, 18 Jul 2012 19:56:04 +0000 (UTC) Date: Wed, 18 Jul 2012 19:56:04 +0000 (UTC) From: "Andy Isaacson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <238162503.71316.1342641364910.JavaMail.jiratomcat@issues-vm> In-Reply-To: <206964470.66710.1342566994327.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3675) libhdfs: follow documented return codes MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417612#comment-13417612 ] Andy Isaacson commented on HDFS-3675: ------------------------------------- +1 lgtm. Thanks! > libhdfs: follow documented return codes > --------------------------------------- > > Key: HDFS-3675 > URL: https://issues.apache.org/jira/browse/HDFS-3675 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs > Affects Versions: 2.0.1-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-3675.001.patch, HDFS-3675.002.patch > > > libhdfs should follow its own documentation for return codes. This means always setting errno, and in most cases returning -1 (not some other value) on error. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira