Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D3FCC769 for ; Wed, 11 Jul 2012 16:06:38 +0000 (UTC) Received: (qmail 24471 invoked by uid 500); 11 Jul 2012 16:06:36 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24318 invoked by uid 500); 11 Jul 2012 16:06:36 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24188 invoked by uid 99); 11 Jul 2012 16:06:36 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 16:06:36 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 10A4C142850 for ; Wed, 11 Jul 2012 16:06:36 +0000 (UTC) Date: Wed, 11 Jul 2012 16:06:36 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1801688003.36109.1342022796071.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1862869495.20365.1341770254494.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3615) Two BlockTokenSecretManager findbugs warnings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411674#comment-13411674 ] Aaron T. Myers commented on HDFS-3615: -------------------------------------- No tests are included since this is just a simple findbugs warning fix that doesn't change any behavior. Thanks for the review, Eli. I'm going to commit this momentarily. > Two BlockTokenSecretManager findbugs warnings > --------------------------------------------- > > Key: HDFS-3615 > URL: https://issues.apache.org/jira/browse/HDFS-3615 > Project: Hadoop HDFS > Issue Type: Bug > Components: security > Affects Versions: 2.0.0-alpha > Reporter: Eli Collins > Assignee: Aaron T. Myers > Attachments: HDFS-3615.patch > > > Looks like two findbugs warnings were introduced recently (see these across a couple recent patches). Unclear what change introduced it as the file hasn't been modified and recent committed changes pass the findbugs check. > IS Inconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.keyUpdateInterval; locked 75% of time > IS Inconsistent synchronization of org.apache.hadoop.hdfs.security.token.block.BlockTokenSecretManager.serialNo; locked 75% of time -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira