Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Sat, 14 Jul 2012 21:50:34 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1772708092.53388.1342302634416.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <737944564.77085.1341188425757.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3583) Convert remaining tests to Junit4
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414517#comment-13414517 ] 

Hadoop QA commented on HDFS-3583:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536289/hdfs-3583.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 259 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    -1 findbugs.  The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-raid:

                  org.apache.hadoop.hdfs.server.namenode.TestBackupNode
                  org.apache.hadoop.hdfs.TestDatanodeBlockScanner
                  org.apache.hadoop.raid.TestRaidNode

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2826//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/2826//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs-raid.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2826//console

This message is automatically generated.
                
> Convert remaining tests to Junit4
> ---------------------------------
>
>                 Key: HDFS-3583
>                 URL: https://issues.apache.org/jira/browse/HDFS-3583
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Andrew Wang
>              Labels: newbie
>         Attachments: hdfs-3583.patch, hdfs-3583.patch, junit3to4.sh
>
>
> JUnit4 style tests are easier to debug (eg can use @Timeout etc), let's convert the remaining tests over to Junit4 style.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira