Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A2E8C7A6 for ; Wed, 11 Jul 2012 18:49:41 +0000 (UTC) Received: (qmail 26310 invoked by uid 500); 11 Jul 2012 18:49:40 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 26242 invoked by uid 500); 11 Jul 2012 18:49:40 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 26140 invoked by uid 99); 11 Jul 2012 18:49:40 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jul 2012 18:49:40 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id A04A914285A for ; Wed, 11 Jul 2012 18:49:40 +0000 (UTC) Date: Wed, 11 Jul 2012 18:49:40 +0000 (UTC) From: "Andy Isaacson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1716027256.37199.1342032580658.JavaMail.jiratomcat@issues-vm> In-Reply-To: <102747357.32737.1341966394900.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3633) libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411841#comment-13411841 ] Andy Isaacson commented on HDFS-3633: ------------------------------------- +1, LGTM. > libhdfs: hdfsDelete should pass JNI_FALSE or JNI_TRUE > ----------------------------------------------------- > > Key: HDFS-3633 > URL: https://issues.apache.org/jira/browse/HDFS-3633 > Project: Hadoop HDFS > Issue Type: Bug > Components: libhdfs > Affects Versions: 2.0.1-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HDFS-3633.001.patch > > > In libhdfs in hdfsDelete, the header file says any non-zero argument to hdfsDelete will be interpreted as true. However, the hdfsDelete function does not translate these non-zero values to JNI_FALSE and JNI_TRUE, potentially leading to undefined or JVM-specific behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira