Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5956DA86 for ; Tue, 24 Jul 2012 14:41:36 +0000 (UTC) Received: (qmail 33205 invoked by uid 500); 24 Jul 2012 14:41:36 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 32942 invoked by uid 500); 24 Jul 2012 14:41:36 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 32879 invoked by uid 99); 24 Jul 2012 14:41:35 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jul 2012 14:41:35 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id D9A89142838 for ; Tue, 24 Jul 2012 14:41:34 +0000 (UTC) Date: Tue, 24 Jul 2012 14:41:34 +0000 (UTC) From: "Conrad Meyer (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1711089582.95889.1343140894893.JavaMail.jiratomcat@issues-vm> In-Reply-To: <40138863.70514.1342636655028.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HDFS-3679) fuse_dfs notrash option sets usetrash MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421449#comment-13421449 ] Conrad Meyer commented on HDFS-3679: ------------------------------------ Great, thanks. > fuse_dfs notrash option sets usetrash > ------------------------------------- > > Key: HDFS-3679 > URL: https://issues.apache.org/jira/browse/HDFS-3679 > Project: Hadoop HDFS > Issue Type: Bug > Components: fuse-dfs > Affects Versions: 1.0.0, 1.0.1, 1.0.2, 1.0.3, 2.0.0-alpha > Reporter: Conrad Meyer > Assignee: Conrad Meyer > Priority: Minor > Attachments: hdfs-3679.diff > > Original Estimate: 1m > Remaining Estimate: 1m > > fuse_dfs sets usetrash option when the "notrash" flag is given. This is the exact opposite of the desired behavior. The "usetrash" flag sets usetrash as well, but this is correct. Here are the relevant lines from fuse_options.c, in latest HDFS HEAD[0]: > 123 case KEY_USETRASH: > 124 options.usetrash = 1; > 125 break; > 126 case KEY_NOTRASH: > 127 options.usetrash = 1; > 128 break; > This is a pretty trivial bug to fix. I'm not familiar with the process here, but I can attach a patch if needed. > [0]: https://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/native/fuse-dfs/fuse_options.c?view=markup -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira