Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 31 Jul 2012 23:24:34 +0000 (UTC)
From: "Colin Patrick McCabe (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1446983465.124346.1343777074791.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1392207568.69303.1340921384485.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3579) libhdfs: fix exception handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426214#comment-13426214 ] 

Colin Patrick McCabe commented on HDFS-3579:
--------------------------------------------

Thanks for the review, Andy.  I'm looking forward to the next comment.

bq. [O_WRONLY discussion]

I held off on the O_WRONLY fixes, since we have HDFS-3710 open for that.  What I've done here is just move the code, not add any new (mis)uses.

bq. [linker script discussion]

Yeah, HDFS-3742 is open for this.

I tried to fix as much whitespace as I could; I'm sure there's still funky stuff lingering somewhere.  We can always circle back on that later, though-- as long as this patch moves things in the right direction.
                
> libhdfs: fix exception handling
> -------------------------------
>
>                 Key: HDFS-3579
>                 URL: https://issues.apache.org/jira/browse/HDFS-3579
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: libhdfs
>    Affects Versions: 2.0.1-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-3579.004.patch, HDFS-3579.005.patch, HDFS-3579.006.patch
>
>
> libhdfs does not consistently handle exceptions.  Sometimes we don't free the memory associated with them (memory leak).  Sometimes we invoke JNI functions that are not supposed to be invoked when an exception is active.
> Running a libhdfs test program with -Xcheck:jni shows the latter problem clearly:
> {code}
> WARNING in native method: JNI call made with exception pending
> WARNING in native method: JNI call made with exception pending
> WARNING in native method: JNI call made with exception pending
> WARNING in native method: JNI call made with exception pending
> WARNING in native method: JNI call made with exception pending
> Exception in thread "main" java.io.IOException: ...
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira