Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 5 Jul 2012 20:35:34 +0000 (UTC)
From: "Jason Lowe (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <1066706468.10778.1341520534896.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <943798044.10663.1341519094865.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3603) TestHDFSTrash is failing
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407461#comment-13407461 ] 

Jason Lowe commented on HDFS-3603:
----------------------------------

Failure is:

{noformat}
testTrashEmptier(org.apache.hadoop.hdfs.TestHDFSTrash)  Time elapsed: 0.025 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:47)
        at junit.framework.Assert.assertTrue(Assert.java:20)
        at junit.framework.Assert.assertTrue(Assert.java:27)
        at org.apache.hadoop.fs.TestTrash.testTrashEmptier(TestTrash.java:536)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at junit.framework.TestCase.runTest(TestCase.java:168)
        at junit.framework.TestCase.runBare(TestCase.java:134)
        at junit.framework.TestResult$1.protect(TestResult.java:110)
        at junit.framework.TestResult.runProtected(TestResult.java:128)
        at junit.framework.TestResult.run(TestResult.java:113)
        at junit.framework.TestCase.run(TestCase.java:124)
        at junit.framework.TestSuite.runTest(TestSuite.java:243)
        at junit.framework.TestSuite.run(TestSuite.java:238)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
        at junit.framework.TestResult.runProtected(TestResult.java:128)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:83)
        at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
        at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
        at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
        at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
        at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
{noformat}

Problem seems to have been triggered since HADOOP-8110 was integrated, although that appears to have uncovered an existing issue rather than causing it.  Here's what's happening:

* TestViewFSTrash runs and can end up leaving 4 things in the trash, like:

{noformat}
$ ls ~/.Trash
120705182754  120705182754-1  120705182754-2  Current
{noformat}

* TestHDFSTrash runs testTrashEmptier, sees there are 4 things in the trash, and since it has found 4 checkpoints, it immediately asserts if the current trash directory listing is < 4.  The 4 < 4 assert fails the test.  

* If there are fewer than 4 things in the trash when testTrashEmptier starts, the test will pass.  If there are more than 4 things in the trash when testTrashEmptier starts then it can hang, see HADOOP-7326.

The saddest thing is TestHDFSTrash isn't even testing HDFS when it runs testTrashEmptier, because that test simply uses a local filesystem config.  TestHDFSTrash is picking it up because it inherits from TestTrash which contains that test case.
                
> TestHDFSTrash is failing
> ------------------------
>
>                 Key: HDFS-3603
>                 URL: https://issues.apache.org/jira/browse/HDFS-3603
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.23.3, 2.0.1-alpha, 3.0.0
>            Reporter: Jason Lowe
>            Priority: Blocker
>
> TestHDFSTrash is failing pretty regularly during test builds.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira