Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAA9FD522 for ; Sun, 8 Jul 2012 14:04:36 +0000 (UTC) Received: (qmail 3643 invoked by uid 500); 8 Jul 2012 14:04:36 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 3366 invoked by uid 500); 8 Jul 2012 14:04:36 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 3347 invoked by uid 99); 8 Jul 2012 14:04:36 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Jul 2012 14:04:36 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 0EE3D141887 for ; Sun, 8 Jul 2012 14:04:36 +0000 (UTC) Date: Sun, 8 Jul 2012 14:04:36 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1041979335.20025.1341756276062.JavaMail.jiratomcat@issues-vm> In-Reply-To: <630820284.6485.1329948955835.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2988) Improve error message when storage directory lock fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-2988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408925#comment-13408925 ] Hudson commented on HDFS-2988: ------------------------------ Integrated in Hadoop-Mapreduce-trunk #1130 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1130/]) HDFS-2988. Improve error message when storage directory lock fails. Contributed by Miomir Boljanovic. (harsh) (Revision 1358683) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1358683 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/common/Storage.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java > Improve error message when storage directory lock fails > ------------------------------------------------------- > > Key: HDFS-2988 > URL: https://issues.apache.org/jira/browse/HDFS-2988 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Todd Lipcon > Priority: Minor > Labels: newbie > Fix For: 2.0.1-alpha > > Attachments: HDFS-2988.patch, HDFS-2988.patch, HDFS-2988.patch, HDFS-2988.patch > > > Currently, the error message is fairly opaque to a non-developer ("Cannot lock storage" or something). Instead, we should have some improvments: > - when we create the in_use.lock file, we should write the hostname/PID that locked the file > - if the lock fails, and in_use.lock exists, the error message should say something like "It appears that another namenode (pid 23423 on host foo.example.com) has already locked the storage directory." > - if the lock fails, and no lock file exists, the error message should say something like "if this storage directory is mounted via NFS, ensure that the appropriate nfs lock services are running." -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira