hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3625) FSN#startActiveServices assumes standby services started
Date Mon, 16 Jul 2012 08:01:41 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414911#comment-13414911
] 

Hadoop QA commented on HDFS-3625:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536595/HDFS-3625.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2831//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2831//console

This message is automatically generated.
                
> FSN#startActiveServices assumes standby services started 
> ---------------------------------------------------------
>
>                 Key: HDFS-3625
>                 URL: https://issues.apache.org/jira/browse/HDFS-3625
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: ha
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: HDFS-3625.patch, HDFS-3625.patch
>
>
> TestBackupNode#testCheckpointNode fails because the following code in FSN#startActiveServices
NPEs (resulting in a System.exit) because editLogTailer is set when starting standby services
and if ha is not enabled we go directly to the active state. Looks like it should be wrapped
with an haEnabled check.
> {code}
> LOG.info("Catching up to latest edits from old active before " +
>    "taking over writer role in edits logs.");
> editLogTailer.catchupDuringFailover();
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message