hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3582) Hook System.exit in MiniDFSCluster
Date Mon, 02 Jul 2012 05:20:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404893#comment-13404893
] 

Hadoop QA commented on HDFS-3582:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12534177/hdfs-3582.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestConnCache

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2729//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2729//console

This message is automatically generated.
                
> Hook System.exit in MiniDFSCluster
> ----------------------------------
>
>                 Key: HDFS-3582
>                 URL: https://issues.apache.org/jira/browse/HDFS-3582
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3582.txt
>
>
> Occasionally the tests fail with "java.util.concurrent.ExecutionException: org.apache.maven.surefire.booter.SurefireBooterForkException:
> Error occurred in starting fork, check output in log" because the NN is exit'ing (via
System.exit or Runtime.exit). Unfortunately Surefire doesn't retain the log output (see SUREFIRE-871)
so the test log is empty, we don't know which part of the test triggered which exit in HDFS.
To make this debuggable, let's hook this in MiniDFSCluster  via installing a security manager
that overrides checkExit (ala TestClusterId) or mock out System.exit in the code itself. I
think the former is preferable though we'll need to keep the door open for tests that want
to set their own security manager (should be fine to override this one some times).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message