hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3721) hsync support broke wire compatibility
Date Tue, 31 Jul 2012 22:24:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426176#comment-13426176
] 

Aaron T. Myers commented on HDFS-3721:
--------------------------------------

The patch looks pretty good to me, and I agree it's a good refactor to make RemoteBlockReader
and RemoteBlockReader2 share some code.

One tiny nit on the code, it looks like you have some extra whitespace here:
{code}
if ( checksumBuf.capacity() != checksumLen) {
{code}

It looks to me like the TestFileConcurrentReader failure is due to this patch. I can't recall
that test being flaky, and at least on my box the test passes without this patch, but fails
with it applied.
                
> hsync support broke wire compatibility
> --------------------------------------
>
>                 Key: HDFS-3721
>                 URL: https://issues.apache.org/jira/browse/HDFS-3721
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, hdfs client
>    Affects Versions: 2.1.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-3721.txt
>
>
> HDFS-744 added support for hsync to the data transfer wire protocol. However, it actually
broke wire compatibility: if the client has hsync support but the server does not, the client
cannot read or write data on the old cluster.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message