hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harsh J (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3659) add the missed @Override to methods
Date Sat, 14 Jul 2012 02:11:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13414267#comment-13414267
] 

Harsh J commented on HDFS-3659:
-------------------------------

+1 to the idea. There are two cases of bad indentation in your patch you may want to fix though:

For example:
{code}
-           public Writable newInstance() { return new BlockTwo(); }
+           @Override
+          public Writable newInstance() { return new BlockTwo(); }
{code}

And,

{code}
-         public Writable newInstance() { return new Block(); }
+         @Override
+        public Writable newInstance() { return new Block(); }
{code}

Otherwise, +1 pending jenkins on fixed patch. Thanks Brandon!
                
> add  the missed @Override to methods
> ------------------------------------
>
>                 Key: HDFS-3659
>                 URL: https://issues.apache.org/jira/browse/HDFS-3659
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>            Priority: Minor
>         Attachments: HDFS-3659.patch
>
>
> Adding @Override to the proper methods to take advantage of the compiler checking and
make the code more readable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message