hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3667) Add retry support to WebHdfsFileSystem
Date Fri, 20 Jul 2012 17:29:35 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419365#comment-13419365
] 

Suresh Srinivas commented on HDFS-3667:
---------------------------------------

Comments for the patch:
# WebHdfsFileSystem.java
#* #getWebHdfs throws unnecessary InterruptedException, URISyntaxException
#* #toIOException() please add some brief comments to describe it
#* Please add javadoc to Runner class
# Unrelated to this patch, I get a warning - The field PutOpParam.Op#NULL is hiding a field
from type Param<PutOpParam.Op,EnumParam.Domain<PutOpParam.Op>>. Same for PostOpParam,
GetOpParam and DeleteOpParam.
# Remove unnecessary cast to DistributedFileSystem in TestDelegationTokenForProxyUser#testDelegationTokenWithRealUser.
# Please add javadoc to TestWebhdfsRetries and describe what test the class is for.


bq.  I think this is touching code introduced by HA, so it may be a challenge to merge into
23?
As you pointed, with HA changes, we already have an issue in being able to merge changes from
trunk to 0.23. We may need to do a separate patches in some cases.

                
> Add retry support to WebHdfsFileSystem
> --------------------------------------
>
>                 Key: HDFS-3667
>                 URL: https://issues.apache.org/jira/browse/HDFS-3667
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: webhdfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h3667_20120718.patch
>
>
> DFSClient (i.e. DistributedFileSystem) has a configurable retry policy and it retries
on exceptions such as connection failure, safemode.  WebHdfsFileSystem should have similar
retry support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message