hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3721) hsync support broke wire compatibility
Date Tue, 31 Jul 2012 22:34:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426182#comment-13426182

Suresh Srinivas commented on HDFS-3721:

Todd, I meant to review this. But the code refactoring, even though it is a good idea, has
made the review difficult. Given that I may not be able to get though my code review, in a
short period of time, here are the comments I had based on my review so far:

# DFSOutputStream.java
#* Packet consturctor, can you please add javadoc (especially to describe pktSize)
#* Math in computePacketChunkSize seems correct, but it results in different value from previous
# PacketReceiver.java
#* Make #bufferPool final
# PacketHeader.java
#* Builder import not used
#* Please add javadoc on PacketHeader structure
#* BlockSender.java javadoc could just point to the javadoc of PacketHeader for header information.
We have this in multiple places.

> hsync support broke wire compatibility
> --------------------------------------
>                 Key: HDFS-3721
>                 URL: https://issues.apache.org/jira/browse/HDFS-3721
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, hdfs client
>    Affects Versions: 2.1.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Critical
>         Attachments: hdfs-3721.txt
> HDFS-744 added support for hsync to the data transfer wire protocol. However, it actually
broke wire compatibility: if the client has hsync support but the server does not, the client
cannot read or write data on the old cluster.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message