hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3680) Allows customized audit logging in HDFS FSNamesystem
Date Fri, 20 Jul 2012 04:28:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418915#comment-13418915
] 

Todd Lipcon commented on HDFS-3680:
-----------------------------------

bq. It's not too unusual to have lots of FSNamesystem objects within a single JVM

I think you're confusing FSNamesystem with another class, Andy. There's only one per NN. So
I don't think it should be a singleton at all.

bq. I don't like the hackiness of your change to logAuditEvent; I would prefer to see the
existing StringBuilder-based file logging implementation turned into the premier plugin to
the FSAccessLogger interface. As a bonus, this gives us a feel for how good the plugin interface
is to code against.

I vaguely agree - but that implies that you might want to have multiple plugins installed
at once. I can see, for example, wanting to continue to log to the existing audit logs, but
additionally save to a database, etc.
                
> Allows customized audit logging in HDFS FSNamesystem
> ----------------------------------------------------
>
>                 Key: HDFS-3680
>                 URL: https://issues.apache.org/jira/browse/HDFS-3680
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Marcelo Vanzin
>            Assignee: Marcelo Vanzin
>            Priority: Minor
>         Attachments: accesslogger-v1.patch, accesslogger-v2.patch
>
>
> Currently, FSNamesystem writes audit logs to a logger; that makes it easy to get audit
logs in some log file. But it makes it kinda tricky to store audit logs in any other way (let's
say a database), because it would require the code to implement a log appender (and thus know
what logging system is actually being used underneath the fa├žade), and parse the textual
log message generated by FSNamesystem.
> I'm attaching a patch that introduces a cleaner interface for this use case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message