hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-3190) Simple refactors in existing NN code to assist QuorumJournalManager extension
Date Mon, 02 Jul 2012 18:15:23 GMT

     [ https://issues.apache.org/jira/browse/HDFS-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HDFS-3190:
------------------------------

    Attachment: hdfs-3190.txt

Thanks for the review, Suresh. Here's an updated patch.

- Fixed the 80+ long lines.
- Improved javadoc on StorageErrorReporter
- Renamed PersistentLong to PersistentLongFile

I also removed {{reportErrorOnDirectory}} from the error reporting interface, in order to
simplify it. The only caller was FileJournalManager, and it was easy to change it to just
report on the actual files that had an error. Seemed worth simplifying the API here.
                
> Simple refactors in existing NN code to assist QuorumJournalManager extension
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-3190
>                 URL: https://issues.apache.org/jira/browse/HDFS-3190
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 2.0.0-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt, hdfs-3190.txt
>
>
> This JIRA is for some simple refactors in the NN:
> - refactor the code which writes the seen_txid file in NNStorage into a new "LongContainingFile"
utility class. This is useful for the JournalNode to atomically/durably record its last promised
epoch
> - refactor the interface from FileJournalManager back to StorageDirectory to use a StorageErrorReport
interface. This allows FileJournalManager to be used in isolation of a full StorageDirectory.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message