hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3583) Convert remaining tests to Junit4
Date Tue, 10 Jul 2012 21:54:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410971#comment-13410971
] 

Aaron T. Myers commented on HDFS-3583:
--------------------------------------

bq. That case seems hard to regex and fix automatically. If it's rare enough, we could just
lump it under "fix manually". Listing all of these manual fix cases (if there are more) would
be useful.

Agree - totally fine to fix all these manually. I found a few (all?) by running this command:
`{{fgrep -r 'suite()' .}}'

bq. Is there an easy way of counting the # of tests with maven besides running the full test
suite? That's one thing I want to make sure we take care of.

I don't know of any way to do that, unfortunately. I'm under the impression that Surefire
just does something close to `find . -name Test*.java' to find the test classes, and then
uses reflection to identify the individual test methods.
                
> Convert remaining tests to Junit4
> ---------------------------------
>
>                 Key: HDFS-3583
>                 URL: https://issues.apache.org/jira/browse/HDFS-3583
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Andrew Wang
>              Labels: newbie
>         Attachments: junit3to4.sh
>
>
> JUnit4 style tests are easier to debug (eg can use @Timeout etc), let's convert the remaining
tests over to Junit4 style.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message