hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-3582) Hook System.exit in MiniDFSCluster
Date Mon, 02 Jul 2012 16:15:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-3582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405097#comment-13405097
] 

Alejandro Abdelnur commented on HDFS-3582:
------------------------------------------

@Eli, it would be great if the Minicluster code itself does not poke with the SecurityManager.
Instead, it should be the testcase the one doing that. Else, this will break other testcases
that poke with SecurityManager and use Minicluster (Oozie has a few of those).
                
> Hook System.exit in MiniDFSCluster
> ----------------------------------
>
>                 Key: HDFS-3582
>                 URL: https://issues.apache.org/jira/browse/HDFS-3582
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.0-alpha
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>         Attachments: hdfs-3582.txt
>
>
> Occasionally the tests fail with "java.util.concurrent.ExecutionException: org.apache.maven.surefire.booter.SurefireBooterForkException:
> Error occurred in starting fork, check output in log" because the NN is exit'ing (via
System.exit or Runtime.exit). Unfortunately Surefire doesn't retain the log output (see SUREFIRE-871)
so the test log is empty, we don't know which part of the test triggered which exit in HDFS.
To make this debuggable, let's hook this in MiniDFSCluster  via installing a security manager
that overrides checkExit (ala TestClusterId) or mock out System.exit in the code itself. I
think the former is preferable though we'll need to keep the door open for tests that want
to set their own security manager (should be fine to override this one some times).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message