Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 25 Jun 2012 08:35:43 +0000 (UTC)
From: "Junping Du (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <955642926.50347.1340613343753.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3498) Make ReplicaPlacementPolicyDefault
 extensible for reuse code in subclass
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400363#comment-13400363 ] 

Junping Du commented on HDFS-3498:
----------------------------------

File a separated JIRA HADOOP-8526 to fix this issue.
                
> Make ReplicaPlacementPolicyDefault extensible for reuse code in subclass
> ------------------------------------------------------------------------
>
>                 Key: HDFS-3498
>                 URL: https://issues.apache.org/jira/browse/HDFS-3498
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Junping Du
>            Assignee: Junping Du
>         Attachments: HDFS-3498-v2.patch, HDFS-3498-v3.patch, HDFS-3498-v4.patch, HDFS-3498.patch, Hadoop-8471-BlockPlacementDefault-extensible.patch
>
>
> ReplicaPlacementPolicy is already a pluggable component in Hadoop. However, the Replica Removal Policy is still nested in BlockManager that need to be separated out into a ReplicaPlacementPolicy then can be override later. Also it looks like hadoop unit test lack the testing on replica removal policy, so we add it here.
> On the other hand, as a implementation of ReplicaPlacementPolicy, ReplicaPlacementDefault still show lots of generic for other topology cases like: virtualization, and we want to make code in ReplicaPlacementPolicyDefault can be reused as much as possible so a few of its methods were changed from private to protected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira