Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 12 Jun 2012 16:26:43 +0000 (UTC)
From: "Harsh J (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <473838238.8207.1339518403051.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1055265972.2012.1339390783086.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HDFS-3522) If NN is in safemode, it should
 throw SafeModeException when getBlockLocations has zero locations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-3522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13293740#comment-13293740 ] 

Harsh J commented on HDFS-3522:
-------------------------------

Unsure why jenkins didn't catch it, but indeed the test fails:

{code}
Running org.apache.hadoop.hdfs.TestFileLengthOnClusterRestart
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 13.127 sec <<< FAILURE!
{code}

(Although it does test for a failure, the failure now is different, and is a regression).

To handle Brandon's specific requirement, we may choose to throw an exception *iff* NN is in safemode for threshold-not-reached reasons. We should not fail reads if an admin places NN manually in safemode for whatever reasons (i.e. blocks are all still known about). This way we're good on both sides. Thoughts?
                
> If NN is in safemode, it should throw SafeModeException when getBlockLocations has zero locations
> -------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-3522
>                 URL: https://issues.apache.org/jira/browse/HDFS-3522
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>             Fix For: 2.0.1-alpha
>
>         Attachments: HDFS-3522.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira